Commit Graph

6 Commits

Author SHA1 Message Date
Chenlei Hu ce759b7db6
Revert download to .tmp in frontend_management (#5369) 2024-10-25 19:26:13 -04:00
Alex "mcmonkey" Goodwin c695c4af7f
Frontend Manager: avoid redundant gh calls for static versions (#5152)
* Frontend Manager: avoid redundant gh calls for static versions

* actually, removing old tmpdir isn't needed

I tested - downloader code handles this case well already
(also rmdir was wrong func anyway, needed shutil.rmtree if it had content)

* add code comment
2024-10-16 03:35:37 -04:00
Chenlei Hu ca4b8f30e0
Cleanup empty dir if frontend zip download failed (#4574) 2024-08-27 02:07:25 -04:00
Chenlei Hu f2298799ba
Fix annotation (#4035) 2024-07-16 18:20:39 -04:00
comfyanonymous e1630391d6 Allow version names like v0.0.1 for the FrontendManager. 2024-07-16 11:29:38 -04:00
Chenlei Hu 99458e8aca
Add `FrontendManager` to manage non-default front-end impl (#3897)
* Add frontend manager

* Add tests

* nit

* Add unit test to github CI

* Fix path

* nit

* ignore

* Add logging

* Install test deps

* Remove 'stable' keyword support

* Update test

* Add web-root arg

* Rename web-root to front-end-root

* Add test on non-exist version number

* Use repo owner/name to replace hard coded provider list

* Inline cmd args

* nit

* Fix unit test
2024-07-16 11:26:11 -04:00